-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-34700][SQL] SessionCatalog's temporary view related APIs should take/return more concrete types #31906
Conversation
} | ||
} | ||
|
||
def getTempViewSchema(plan: LogicalPlan): StructType = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only called from SparkGetColumnsOperation.scala
and now that a raw temp plan always has CatalogTable
, the caller can just directly get the schema from the raw plan, and I don't see a reason to expose this as a def
. Check SparkGetColumnsOperation.scala
changes below.
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #136270 has finished for PR 31906 at commit
|
cc @cloud-fan |
thanks, merging to master! |
What changes were proposed in this pull request?
Now that all the temporary views are wrapped with
TemporaryViewRelation
(#31273, #31652, and #31825), this PR proposes to updateSessionCatalog
's APIs for temporary views to take or return more concrete types.APIs that will take
TemporaryViewRelation
instead ofLogicalPlan
:APIs that will return
TemporaryViewRelation
instead ofLogicalPlan
:APIs that will return
View
instead ofLogicalPlan
:Why are the changes needed?
Internal refactoring to work with more concrete types.
Does this PR introduce any user-facing change?
No, this is internal refactoring.
How was this patch tested?
Updated existing tests affected by the refactoring.