-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35392][ML][PYTHON] Fix flaky tests in ml/clustering.py and ml/feature.py #32533
[SPARK-35392][ML][PYTHON] Fix flaky tests in ml/clustering.py and ml/feature.py #32533
Conversation
ping @HyukjinKwon @srowen @viirya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass
Test build #138498 has finished for PR 32533 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
@zhengruifeng would you mind fixing:
too? feel free to change the JIRA. I think we can just fix it like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test build #138510 has finished for PR 32533 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Merged to master. |
Thanks @zhengruifeng for fixing this! |
Yes, one stone for two birds! Nice! |
What changes were proposed in this pull request?
This PR removes the check of
summary.logLikelihood
in ml/clustering.py - this GMM test is quite flaky. It fails easily e.g., if:Also uses more permissive precision on
Word2Vec
test case.Why are the changes needed?
To recover the build and tests.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test cases.