-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-37867][SQL] Compile aggregate functions of build-in JDBC dialect #35166
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9bb754e
[SPARK-37867][SQL] Compile aggregate functions of build-in JDBC dialect
beliefer fcf6e88
Update code
beliefer d342f86
Update code
beliefer d71b293
Update code
beliefer b9e648d
Update code
beliefer e626cd8
Update code
beliefer fc5f712
Update code
beliefer 8ea6bbd
Update code
beliefer 7aa569a
Update code
beliefer 9c4ff55
Update code
beliefer 7dc4597
Update code
beliefer c23e8e4
Update code
beliefer 4dd1379
Update code
beliefer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...tion-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/DockerJDBCIntegrationV2Suite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.sql.jdbc.v2 | ||
|
||
import java.sql.Connection | ||
|
||
import org.apache.spark.sql.jdbc.DockerJDBCIntegrationSuite | ||
|
||
abstract class DockerJDBCIntegrationV2Suite extends DockerJDBCIntegrationSuite { | ||
|
||
/** | ||
* Prepare databases and tables for testing. | ||
*/ | ||
override def dataPreparation(connection: Connection): Unit = { | ||
tablePreparation(connection) | ||
connection.prepareStatement("INSERT INTO employee VALUES (1, 'amy', 10000, 1000)") | ||
.executeUpdate() | ||
connection.prepareStatement("INSERT INTO employee VALUES (2, 'alex', 12000, 1200)") | ||
.executeUpdate() | ||
connection.prepareStatement("INSERT INTO employee VALUES (1, 'cathy', 9000, 1200)") | ||
.executeUpdate() | ||
connection.prepareStatement("INSERT INTO employee VALUES (2, 'david', 10000, 1300)") | ||
.executeUpdate() | ||
connection.prepareStatement("INSERT INTO employee VALUES (6, 'jen', 12000, 1200)") | ||
.executeUpdate() | ||
} | ||
|
||
def tablePreparation(connection: Connection): Unit | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think DB2 objects names are not case sensitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tests many time. If uses the table name with lower case, DB2 throws Exception about not find table.