[SPARK-37427][PYTHON][MLLIB] Inline typehints for pyspark.mllib.tree #35545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero323
force-pushed
the
SPARK-37427
branch
2 times, most recently
from
c4e49ac to
2c0f363
Compare
zero323
changed the title
HyukjinKwon
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR migrates type
pyspark.mllib.treeannotations from stub file to inline type hints.Why are the changes needed?
Part of ongoing migration of type hints.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.