[SPARK-38175][CORE][FOLLOWUP] Remove urlPattern from HistoryAppStatusStore#replaceLogUrls method signature
#35567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
LuciferYang
commented
Feb 18, 2022
| case None => execSummary | ||
| } | ||
| } | ||
|
|
||
| private def replaceLogUrls(exec: v1.ExecutorSummary, urlPattern: String): v1.ExecutorSummary = { |
There was a problem hiding this comment.
SPARK-26311 defines this method with urlPattern and SPARK-26792 change to use logUrlPattern held by ExecutorLogUrlHandler
LuciferYang
changed the title
urlPattern from HistoryAppStatusStore#replaceLogUrls methods signature
LuciferYang
changed the title
urlPattern from HistoryAppStatusStore#replaceLogUrls methods signatureurlPattern from HistoryAppStatusStore#replaceLogUrls method signature
LuciferYang
changed the title
urlPattern from HistoryAppStatusStore#replaceLogUrls method signatureurlPattern from HistoryAppStatusStore#replaceLogUrls method signature
srowen
reviewed
Feb 18, 2022
| case None => execList | ||
| } | ||
| } | ||
|
|
||
| override def executorSummary(executorId: String): v1.ExecutorSummary = { | ||
| val execSummary = super.executorSummary(executorId) | ||
| logUrlPattern match { | ||
| case Some(pattern) => replaceLogUrls(execSummary, pattern) | ||
| case Some(_) => replaceLogUrls(execSummary) |
There was a problem hiding this comment.
This is fine though could simplify to a condition on logUrlPattern.nonEmpty or something
srowen
reviewed
Feb 18, 2022
| @@ -45,20 +45,21 @@ private[spark] class HistoryAppStatusStore( | |||
| override def executorList(activeOnly: Boolean): Seq[v1.ExecutorSummary] = { | |||
| val execList = super.executorList(activeOnly) | |||
| logUrlPattern match { | |||
| case Some(pattern) => execList.map(replaceLogUrls(_, pattern)) | |||
| case Some(_) => execList.map(replaceLogUrls) | |||
There was a problem hiding this comment.
Sorry, let me fix this too
|
Merged to master |
|
thanks @srowen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is a followup of SPARK-38175 to remove
urlPatternfromHistoryAppStatusStore#replaceLogUrlsmethod signatureWhy are the changes needed?
Cleanup unused symbol.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA