Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-38251][SQL] Change Cast.toString as "cast" instead of "ansi_cast" under ANSI mode #35570

Closed

Conversation

gengliangwang
Copy link
Member

What changes were proposed in this pull request?

Change Cast.toString as "cast" instead of "ansi_cast" under ANSI mode.
This is to restore the behavior before #27608

Why are the changes needed?

  1. There is no such a function "ansi_cast" in Spark SQL
  2. Add/Divide/.. has different behavior under ANSI mode as well, but they don't have this special string representation.
  3. As we are setting up new Github job for ANSI mode, this can avoid test failures from TPCDS plan stability test suites

Does this PR introduce any user-facing change?

Yes but quite minor, the string output of Cast under ANSI mode becomes "cast" instead of "ansi_cast" again.

How was this patch tested?

Existing UT

@gengliangwang
Copy link
Member Author

Merging to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants