[SPARK-41514][K8S][DOCS] Add PVC-oriented executor pod allocation doc and revise config name
#39058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection and revise config name
|
Hi, @viirya . This is the documentation PR. Could you review this when you have some time? |
viirya
approved these changes
Dec 14, 2022
viirya
reviewed
Dec 14, 2022
|
|
||
| In addition, since Spark 3.4, Spark driver is able to do PVC-oriented executor allocation which means | ||
| Spark counts the total number of created PVCs which the cluster can have and holds on a new executor creation | ||
| if the driver owns the maximum number of PVCs. This helps the transition of the existing PVC from one executor |
There was a problem hiding this comment.
Is the maximum number of PVCs limited by cluster capacity?
There was a problem hiding this comment.
Oh, I used the cluster = the spark cluster = the spark job = the spark driver + executor. It could be misleading as the k8s cluster. Let me revise it. Thank you!
|
I replaced |
|
Since the last commit is a word change in the documentation and config description, I'll merge this. Thank you, @viirya ! |
|
Thank you @dongjoon-hyun |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…oc and revise config name ### What changes were proposed in this pull request? This PR aims to add `PVC-oriented executor pod allocation` section to K8s documentation. To be consistent with the existing two configurations, I revise the configuration like the following. ``` - spark.kubernetes.driver.waitToReusePersistentVolumeClaims + spark.kubernetes.driver.waitToReusePersistentVolumeClaim ``` ### Why are the changes needed? To document new feature. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review since this is a documentation. Closes apache#39058 from dongjoon-hyun/SPARK-41514. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
PVC-oriented executor pod allocationsection to K8s documentation.To be consistent with the existing two configurations, I revise the configuration like the following.
Why are the changes needed?
To document new feature.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review since this is a documentation.