[SPARK-5145][Mllib] Add BLAS.dsyr and use it in GaussianMixtureEM #3949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
|
Test build #25221 has finished for PR 3949 at commit
|
|
@viirya I'll look over this ASAP, but in the meantime, could you please add a unit test for it? Thanks! |
| @@ -228,6 +228,29 @@ private[spark] object BLAS extends Serializable with Logging { | |||
| } | |||
| _nativeBLAS | |||
| } | |||
|
|
|||
| /** | |||
| * A := alpha * x * x^T + A | |||
There was a problem hiding this comment.
Can you please add documentation here for each input value, including constraints about dimensions?
Also: Write x^T^ for the Scala doc exponent (enclosing carats).
|
Test build #560 has finished for PR 3949 at commit
|
|
@jkbradley Thanks. The unit test is added. |
|
Test build #25294 has finished for PR 3949 at commit
|
|
@viirya Thanks very much for the updates! LGTM |
|
Merged into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr uses BLAS.dsyr to replace few implementations in GaussianMixtureEM.