[SPARK-43342][K8S] Revert SPARK-39006 Show a directional error message for executor PVC dynamic allocation failure #41069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor PVC dynamic allocation failure" This reverts commit b065c94.
|
cc @dcoliversun This will be merged with your authorship. |
|
After merging this clean-revert, you may want to make a new and proper test PR for https://github.com/apache/spark/pull/41057/files#r1186469992 if you want. |
|
@dongjoon-hyun Thanks for your PR. I'm +1 |
|
Thank you, @dcoliversun . |
|
Could you review this PR, @viirya ? |
|
May I ask why this is reverted? |
|
Sorry for missing context, @viirya . SPARK-43329 and SPARK-43342 were filed as a regression at Apache Spark 3.4.0 and those issues have the error message, I linked all the reported issues to the original JIRA which caused this regression.
And, the following was the reverting PR from the author of SPARK-39006, @dcoliversun. In short, while adding a log message, we missed a corner case which one NFS-backed PVC is mounted by multiple executors. So, we decide to revert SPARK-39006 because it doesn't give actual benefit (except logging). |
viirya
approved these changes
May 7, 2023
|
Thank you @dongjoon-hyun |
|
Thank you! |
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 7, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #41057 Closes #41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Merged to master/3.4. |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <[email protected]>
GladwinLee
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This reverts commit b065c94.
Why are the changes needed?
To remove the regression from SPARK-39006.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Closes #41057