[SPARK-48693][SQL] Simplify and unify toString of Invoke and StaticInvoke #47066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan @LuciferYang @dongjoon-hyun @HyukjinKwon thanks |
HyukjinKwon
reviewed
Jun 25, 2024
...r/connect/common/src/test/resources/query-tests/explain-results/function_aes_decrypt.explain
Show resolved
Hide resolved
cloud-fan
approved these changes
Jun 25, 2024
|
Merged to master, thank you all. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…voke ### What changes were proposed in this pull request? The `StaticInvoke` class is used extensively by `RuntimeReplacable` expressions, due to its ugly string representation, a plan with multiple or nested `StaticInvoke` is hard to read. This PR overrides `StaticInvoke`'s toString method to improve its readability. ```diff Project [left(c7#x, 2) AS left(c7, 2)#x, left(c8#x, 2) AS left(c8, 2)#x, left(v#x, 3) AS left(v, 3)#x, left(s#x, 2) AS left(s, 2)#x] +- SubqueryAlias spark_catalog.default.char_tbl4 - +- Project [staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, readSidePadding, c7#x, 7, tru e, false, true) AS c7#x, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, readSidePadding, c8# x, 8, true, false, true) AS c8#x, v#x, s#x] + +- Project [static_invoke(CharVarcharCodegenUtils.readSidePadding(c7#x, 7)) AS c7#x, static_invoke(CharVarcharCodegenUtils.readSideP adding(c8#x, 8)) AS c8#x, v#x, s#x] ``` In contrast, the `Invoke`'s toString is overly simple, losing its child's string representations. ### Why are the changes needed? improve plan readability and consistency ### Does this PR introduce _any_ user-facing change? Yes, a plan containing `StaticInvoke` will change its string representation. ### How was this patch tested? existing modified tests ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#47066 from yaooqinn/SPARK-48693. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
StaticInvokeclass is used extensively byRuntimeReplacableexpressions, due to its ugly string representation, a plan with multiple or nestedStaticInvokeis hard to read.This PR overrides
StaticInvoke's toString method to improve its readability.In contrast, the
Invoke's toString is overly simple, losing its child's string representations.Why are the changes needed?
improve plan readability and consistency
Does this PR introduce any user-facing change?
Yes, a plan containing
StaticInvokewill change its string representation.How was this patch tested?
existing modified tests
Was this patch authored or co-authored using generative AI tooling?
no