Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49775][SQL][FOLLOW-UP] Use SortedSet instead of Array with sorting #48245

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Sep 25, 2024

What changes were proposed in this pull request?

This PR is a followup of #48235 that addresses #48235 (comment) comment.

Why are the changes needed?

For better performance (in theory)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests should verify them

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 4.0.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-49775-followup branch September 25, 2024 14:57
@dongjoon-hyun dongjoon-hyun restored the SPARK-49775-followup branch September 25, 2024 14:57
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
…ting

### What changes were proposed in this pull request?

This PR is a followup of apache#48235 that addresses apache#48235 (comment) comment.

### Why are the changes needed?

For better performance (in theory)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests should verify them

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#48245 from HyukjinKwon/SPARK-49775-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
…ting

### What changes were proposed in this pull request?

This PR is a followup of apache#48235 that addresses apache#48235 (comment) comment.

### Why are the changes needed?

For better performance (in theory)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests should verify them

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#48245 from HyukjinKwon/SPARK-49775-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants