[SPARK-50619][SQL] Refactor VariantGet.cast to pack the cast arguments #49239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhao-db
force-pushed
the
VariantCastArgs
branch
from
ccbaa08 to
176e7ee
Compare
|
@cashmand @cloud-fan could you help review? Thanks! |
HyukjinKwon
changed the title
cloud-fan
reviewed
Dec 19, 2024
| // Several parameters used by `VariantGet.cast`. Packed together to simplify parameter passing. | ||
| case class VariantCastArgs( | ||
| failOnError: Boolean, | ||
| zoneStr: Option[String], |
There was a problem hiding this comment.
why do we need the original timezone string if we already have the ZoneId?
There was a problem hiding this comment.
oh it's to create the Cast expression
cloud-fan
approved these changes
Dec 19, 2024
|
@cloud-fan could you help merge it? Thanks! |
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As the title. It refactors the code for simplification.
Why are the changes needed?
The refactor will make it simpler for the shredded user to use
VariantGet.cast.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.