[SPARK-50894][SQL] Postgres driver version bump to 42.7.5 #49575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vladanvasi-db Could you set proper tag in PR's title, please. |
HyukjinKwon
approved these changes
Jan 21, 2025
cloud-fan
changed the title
cloud-fan
approved these changes
Jan 21, 2025
|
The failed yarn test is unrelated, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Jan 21, 2025
### What changes were proposed in this pull request? In this PR, I propose upgrading the version of `PostgreSQL` driver version to `42.7.5`. More specifically, in this [PR](#47810), the following regression was introduced: `Postgres` driver was not compatible for connection to the `Redshift` Data Source. This happened because the `42.7.4` driver version unnecessarily sent `SET extra_float_digits = 3` queries to the destination data source when establishing the connection. However, the upper limit for `extra_float_digits` parameter in `Redshift` is 2. Regarding the release notes of version [42.7.5](https://github.com/pgjdbc/pgjdbc/releases/tag/REL42.7.5), I propose to upgrade the version of the driver, because the behavior of sending queries which set `extra_flow_digits` when establishing connection was fixed in this version. ### Why are the changes needed? This changes are essential when trying to properly connect to the Redshift instance from OSS. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49575 from vladanvasi-db/vladanvasi-db/postrgesql-driver-fix. Authored-by: Vladan Vasić <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 1cdb918) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR, I propose upgrading the version of
PostgreSQLdriver version to42.7.5. More specifically, in this PR, the following regression was introduced:Postgresdriver was not compatible for connection to theRedshiftData Source. This happened because the42.7.4driver version unnecessarily sentSET extra_float_digits = 3queries to the destination data source when establishing the connection. However, the upper limit forextra_float_digitsparameter inRedshiftis 2.Regarding the release notes of version 42.7.5, I propose to upgrade the version of the driver, because the behavior of sending queries which set
extra_flow_digitswhen establishing connection was fixed in this version.Why are the changes needed?
This changes are essential when trying to properly connect to the Redshift instance from OSS.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A.
Was this patch authored or co-authored using generative AI tooling?
No.