[SQL][Minor] rename DataTypeParser.apply to DataTypeParser.parse #5710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,7 +92,7 @@ object PhysicalOperation extends PredicateHelper { | |||
| } | |||
|
|
|||
| def collectAliases(fields: Seq[Expression]): Map[Attribute, Expression] = fields.collect { | |||
| case a @ Alias(child, _) => a.toAttribute.asInstanceOf[Attribute] -> child | |||
| case a @ Alias(child, _) => a.toAttribute -> child | |||
There was a problem hiding this comment.
this asInstanceOf is not necessary, also delete it here
|
Test build #30960 has finished for PR 5710 at commit
|
|
Merging in master. Thanks! |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 14, 2015
rename DataTypeParser.apply to DataTypeParser.parse to make it more clear and readable. /cc rxin Author: wangfei <[email protected]> Closes apache#5710 from scwf/apply and squashes the following commits: c319977 [wangfei] rename apply to parse
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
rename DataTypeParser.apply to DataTypeParser.parse to make it more clear and readable. /cc rxin Author: wangfei <[email protected]> Closes apache#5710 from scwf/apply and squashes the following commits: c319977 [wangfei] rename apply to parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename DataTypeParser.apply to DataTypeParser.parse to make it more clear and readable.
/cc @rxin