-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-6259][MLlib] Python API for LDA #6791
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
25ef2ac
Resolve conflicts with rebasing
yu-iskw 68f0653
Support some parameters for `ALS.train()` in Python
yu-iskw 77fd1b7
Not use LabeledPoint
yu-iskw 8117e18
Fix the validation problems by `lint-scala`
yu-iskw 39514ec
Modify how to cast the input data
yu-iskw 2278829
Fix the indentation
yu-iskw 73412c3
Fix the typo
yu-iskw 57ac03d
Remove the unnecessary import in Python unit testing
yu-iskw 98f645a
Remove the interface for `describeTopics`. Because it is not implemen…
yu-iskw faa9764
Add some comments for the LDA paramters
yu-iskw 9f8bed8
Simplify casting
yu-iskw 083e226
Add the comment about the supported values and the default value of `…
yu-iskw d7a332a
Remove the doc comment about the optimizer's default value
yu-iskw 28bd165
Change the place of testing code
yu-iskw 6855f59
LDA inherits object
yu-iskw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer you print out the topics matrix and use
...
to allow small errors in the values.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
...
to compare an array or a list with another one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question; I'm not sure. Feel free to leave it as is, if it does not work easily.