Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-10889] [Streaming] Bump KCL to add MillisBehindLatest metric #8957

Closed
wants to merge 1 commit into from

Conversation

akatz
Copy link
Contributor

@akatz akatz commented Oct 1, 2015

I don't believe the API changed at all.

@srowen
Copy link
Member

srowen commented Oct 1, 2015

Seems OK to me, but the usual question is simply, does it introduce any potential problems too? changes dependencies, incompatible behavior, etc? might skim the release notes and commits if you can to sanity check.

@SparkQA
Copy link

SparkQA commented Oct 1, 2015

Test build #1834 has finished for PR 8957 at commit 6abc571.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class HyperLogLogPlusPlus(child: Expression, relativeSD: Double = 0.05)

@SparkQA
Copy link

SparkQA commented Oct 1, 2015

Test build #1836 has finished for PR 8957 at commit 6abc571.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@akatz
Copy link
Contributor Author

akatz commented Oct 2, 2015

I skimmed the changes, it doesn't seem like they changed the public record processing API at all.

@SparkQA
Copy link

SparkQA commented Oct 2, 2015

Test build #1838 has finished for PR 8957 at commit 6abc571.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class HyperLogLogPlusPlus(child: Expression, relativeSD: Double = 0.05)

asfgit pushed a commit that referenced this pull request Oct 4, 2015
I don't believe the API changed at all.

Author: Avrohom Katz <[email protected]>

Closes #8957 from akatz/kcl-upgrade.

(cherry picked from commit 883bd8f)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member

srowen commented Oct 4, 2015

Merged to master / 1.5

@asfgit asfgit closed this in 883bd8f Oct 4, 2015
@MLnick
Copy link
Contributor

MLnick commented Dec 14, 2015

@akatz did you run the Kinesis-specific tests for this PR? It appears this change may have broken Kinesis Streaming in 1.5.2 - https://mail-archives.apache.org/mod_mbox/spark-user/201512.mbox/%3CCALD%2B6GMXKOR5%3DbGYQhezXbV_qaJsoi2Y2cSbaDETeefWbh84Qg%40mail.gmail.com%3E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants