[WIP][ISSUE-3007][Improve] Introduce a premise utils to reduce conditions check and exceptions processing

[zhengkezhou1]

What changes were proposed in this pull request

Issue Number: close #3007

Brief change log

Add a tool to unify pre-checking and throwing exceptions

Verifying this change

This change added tests and can be verified as follows:

• Added Test to verify the change.

Does this pull request potentially affect one of the following parts

• Dependencies (does it add or upgrade a dependency): (no)

[wolfboys]

good job

[wolfboys]

hi,

Thanks for your contribution! It's a great improvement. However, from my perspective, there are a issue:

The common layer is a globally module where we strive to include common functionalities that are unrelated to specific business logic. Besides providing a data platform based on Spring Boot, StreamPark is also a stream processing development framework. We have provided some Flink|spark rapid development APIs, allowing users to independently leverage the capabilities of the development framework. Looking at it this way, it is not reasonable to place platform-specific logic such as HTTP status codes and backend exception message display in the common layer. These are not common capabilities, and they are not needed by the development framework.

[wolfboys]

I really like this improvement and I'm looking forward to your next submit. 😊

[caicancai]

I will start reviewing this PR if no one reviews it

[wolfboys]

In the current code, the backend still returns error messages to the frontend as before. The key issue is that these error messages are hard-coded and not processed through i18n. You can check out this issue. My suggestion is that after the backend detects an error, it should return a business state code, and the message info for each status code can be handled by the frontend.

[caicancai]

@RocMarshal If you have time, can you help me with the review? Thank you.

[zhengkezhou1]

@RocMarshal @wolfboys I will replaced the hard-coded place in the project soon

[wolfboys]

hi:
There are some conflicts that need to be resolved first

[RocMarshal]

In the current code, the backend still returns error messages to the frontend as before. The key issue is that these error messages are hard-coded and not processed through i18n. You can check out this issue. My suggestion is that after the backend detects an error, it should return a business state code, and the message info for each status code can be handled by the frontend.

+1 for me.

Hi @zzzk1 Thank you for the pr and sorry for the late reply.
thx for @wolfboys @caicancai comments.

How about

• Only introduce a separate XXXUtils in console-service to perform a check with built-in exception binding
• And keep common related checks in Utils.

?

I'd like to more ideas about it~

[wolfboys]

In the current code, the backend still returns error messages to the frontend as before. The key issue is that these error messages are hard-coded and not processed through i18n. You can check out this issue. My suggestion is that after the backend detects an error, it should return a business state code, and the message info for each status code can be handled by the frontend.

+1 for me.

Hi @zzzk1 Thank you for the pr and sorry for the late reply. thx for @wolfboys @caicancai comments.

How about

• Only introduce a separate XXXUtils in console-service to perform a check with built-in exception binding
• And keep common related checks in Utils.

?

I'd like to more ideas about it~

• Only introduce a separate XXXUtils in console-service to perform a check with built-in exception binding
• And keep common related checks in Utils.

+1, This is a good idea