[Improve]Improve streampark-common module base on [6 Testing] #3519
Conversation
zhengkezhou1
force-pushed
the
streampark-common-test
branch
from
8e632c4 to
7c40a07
Compare
|
I will start reviewing this PR if no one reviews it |
| import java.io.{File, FileInputStream} | ||
| import java.nio.file.{Files, Paths} | ||
|
|
||
| object HdfsOperatorTest { |
There was a problem hiding this comment.
There is currently no e2e test, so you can test whether your results are correct.
Improve add Utils test case Improve add Utils test case
zhengkezhou1
force-pushed
the
streampark-common-test
branch
from
fce6a0a to
4fec209
Compare
|
@zzzk1 Thanks for your contribution. Maybe we can add tests one by one |
| val timeStampTestCase: Long = 946656001000L; | ||
|
|
||
| @Test def stringToDateTest(): Unit = { | ||
| val sdf: SimpleDateFormat = new SimpleDateFormat(DateUtils.fullFormat) |
There was a problem hiding this comment.
You can try other forms of testing, For example, https://github.com/apache/incubator-streampark/tree/dev/streampark-flink/streampark-flink-kubernetes-v2/streampark-flink-kubernetes-core/src/test/scala/org/apache/streampark/flink/kubernetes/v2
zhengkezhou1
force-pushed
the
streampark-common-test
branch
from
e0216e0 to
eec092c
Compare
|
Test cases may not take into account time zones |
You can leave comments in your code |
zhengkezhou1
changed the title
zhengkezhou1
force-pushed
the
streampark-common-test
branch
from
e96b8af to
677dd5f
Compare
|
Good job, i will review it later |
What changes were proposed in this pull request
Issue Number: close #3063
Brief change log
add scalatest dependency to streampark-common pom.xml
add mockito-scala_2.12 dependency to streampark-common pom.xml
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts