Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add missing leading slash in CHECK API endpoint #4197

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

goby-ao
Copy link
Contributor

@goby-ao goby-ao commented Mar 3, 2025

What changes were proposed in this pull request

If adding context-path config as follow,an error occurs when clicking the cURL copy button.

  servlet:
    context-path: /streampark

Xnip2025-03-03_16-49-27

This pull request fixes an inconsistency in the Api enum by adding a missing leading slash to the CHECK endpoint. The change ensures that all endpoints follow the same pattern, preventing potential routing issues. Additionally, I updated the related unit tests to reflect this change.

Brief change log

This commit adds the
missing slash to maintain consistency across all API path definitions
and prevent potential routing issues.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (no)

@github-actions github-actions bot added the WEB UI label Mar 3, 2025
Copy link

sonarqubecloud bot commented Mar 3, 2025

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 1ded050 into apache:dev Mar 6, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants