[#877] remove reluctant onDestroy

apache · Jan 21, 2023 · 075114e · 075114e
1 parent 1d3cd42
commit 075114e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/ui/src/app/data-explorer/components/widgets/heatmap/heatmap-widget.component.ts b/ui/src/app/data-explorer/components/widgets/heatmap/heatmap-widget.component.ts
@@ -16,7 +16,7 @@
  *
  */
 
-import { Component, OnDestroy, OnInit } from '@angular/core';
+import { Component, OnInit } from '@angular/core';
 import {
     DataExplorerField,
     SpQueryResult,
@@ -35,7 +35,7 @@ import { ECharts } from 'echarts/core';
 })
 export class HeatmapWidgetComponent
     extends BaseDataExplorerWidgetDirective<HeatmapWidgetModel>
-    implements OnInit, OnDestroy
+    implements OnInit
 {
     eChartsInstance: ECharts;
     currentWidth: number;
@@ -55,10 +55,6 @@ export class HeatmapWidgetComponent
         this.initOptions();
     }
 
-    ngOnDestroy(): void {
-        super.ngOnDestroy();
-    }
-
     public refreshView() {}
 
     onResize(width: number, height: number) {

diff --git a/ui/src/app/data-explorer/components/widgets/map/map-widget.component.ts b/ui/src/app/data-explorer/components/widgets/map/map-widget.component.ts
@@ -16,7 +16,7 @@
  *
  */
 
-import { Component, OnDestroy, OnInit } from '@angular/core';
+import { Component, OnInit } from '@angular/core';
 import {
     Content,
     icon,
@@ -45,7 +45,7 @@ import {
 })
 export class MapWidgetComponent
     extends BaseDataExplorerWidgetDirective<MapWidgetModel>
-    implements OnInit, OnDestroy
+    implements OnInit
 {
     item: any;
 
@@ -90,10 +90,6 @@ export class MapWidgetComponent
         this.showMarkers = true;
     }
 
-    ngOnDestroy(): void {
-        super.ngOnDestroy();
-    }
-
     markerImage(selectedMarker: string): string {
         return selectedMarker === 'Default'
             ? 'assets/img/marker-icon.png'