Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub wofklow that tags PR #1104

Closed
2 tasks done
bossenti opened this issue Jan 16, 2023 · 9 comments · Fixed by #1142
Closed
2 tasks done

Add GitHub wofklow that tags PR #1104

bossenti opened this issue Jan 16, 2023 · 9 comments · Fixed by #1142
Assignees
Labels
gh-actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Milestone

Comments

@bossenti
Copy link
Contributor

bossenti commented Jan 16, 2023

Body

Implement a GitHub workflow that automatically assigns labels to PRs.
Fur this purpose consider to use the following GitHub action: https://github.com/actions/labeler

ToDos:

  • provide config file to define labeling rules
  • implement GitHub workflow that runs for every created PR and assigns labels to it

Metoring

As this ticket is marked as good first issue: one of @dominikriemer, @tenthe, or @bossenti are happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help.
It would be great if you discover our repository by yourself (this is a great oppurtinity to get to know the basic StreamPipes components) and come up with a proposal for labeling rules. But if you struggle with that we are happy to help you making a first draft.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

@bossenti bossenti added good first issue Good for newcomers gh-actions Pull requests that update GitHub Actions code labels Jan 16, 2023
@bossenti bossenti added this to the 1.0.0 milestone Jan 16, 2023
@Harry262530
Copy link
Contributor

Hello,
I would like to contribute in this issue

@bossenti
Copy link
Contributor Author

Hi @Harry262530, awesome 🤩
Do you need any help for getting started?

@Harry262530
Copy link
Contributor

Ya,
Actually i have experience in coding but I am pretty new in contribution
Can you please guide how can i get started

@bossenti
Copy link
Contributor Author

Okay, the first step is to fork this repository to your own GitHub account.
Next, check out your own fork and create a branch which should ideally be named 1104-add-github-wofklow-that-tags-pr (or similar).
Then you already can start with implementing the GitHub workflow.
You can find all our existing workflows in .github.

Once you have the workflow ready, you can create a PR in this repository and we will review you it
Feel free to reach out in case you get stuck :)

@Harry262530
Copy link
Contributor

sure
i'll try my best

@Harry262530
Copy link
Contributor

I need a little Guidance,
I have created a branch of this repo and I have thoroughly gone through labeler repo and workflow of this repo, now I am stuck at how to start working with the workflow and including labels.

@bossenti
Copy link
Contributor Author

Okay, so at first we want to have an additional workflow. So there is no need to integrate with the existing ones.
You can create a new file and call it e.g. pr-labeling.yaml.
This workflow should be executed when a PR is created.
Here you can follow the example of labeler pretty close: https://github.com/actions/labeler#create-workflow
The more difficult part is the configuration file. If you want to, you can take some time and familiarize your self with our existing labels and the codebase and come up with a proposal.
But you don't need to, you can also just provide the workflow itself and we will then come up with the configuration file.

Does this help you?

@bossenti
Copy link
Contributor Author

bossenti commented Jan 20, 2023

@Harry262530
Copy link
Contributor

I have created a pull request for the workflow and config file
can you please go through them

@bossenti bossenti linked a pull request Jan 21, 2023 that will close this issue
2 tasks
bossenti added a commit to Harry262530/streampipes that referenced this issue Jan 25, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Jan 25, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Jan 25, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Jan 25, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Jan 25, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Feb 1, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Feb 1, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Feb 1, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Feb 1, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Feb 1, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Feb 1, 2023
bossenti added a commit to Harry262530/streampipes that referenced this issue Feb 1, 2023
bossenti added a commit that referenced this issue Feb 1, 2023
* Create prlabelling.yaml

* pull request labeler rules

* config file for merging label rules

* updated pull request target

* filter pr created by dependabot

* removed repo label from every  pr

* [#1104] remove unnecessary config file

* [#1104] provide initial version of StreamPipes label config

* [#1104] restrict pr events & provide config path

* [#1104] refactor file names

* [#1104] add Apache license header

* [#1104] refine labeler config

* [#1104] add sync configuration

---------

Co-authored-by: bossenti <[email protected]>
@bossenti bossenti removed this from the 1.0.0 milestone Feb 9, 2023
@bossenti bossenti added this to the 0.91.0 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gh-actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants