Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session based implementation of IoTDB sink (fix issues in current JDBC based implementation) #1146

Closed
SteveYurongSu opened this issue Jan 23, 2023 · 1 comment · Fixed by #1166
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SteveYurongSu
Copy link
Member

Apache StreamPipes version

dev (current development state)

Affected StreamPipes components

Connect

What happened?

Recently, I was trying to play around streampipes and found that iotdb sink could not work properly.

I checked the source code and found that the current JDBC based implementation of iotdb sink is outdated, especially for the current production versions of iotdb (0.13.x and 1.0.x).

I‘d like to contribute a brand new iotdb sink implementation, which has the following features:

  • Support production ready versions of IoTDB (version >= 0.13.0)
  • Support by iotdb-session API, which can provide higher throughput and lower latency
  • Support schema-less write: no need to create storage group (database) before insertion

How to reproduce?

Graph:
Water Level 1 -> IoTDB

I debugged the iotdb sink in pipeline-element mode and found that the current iotdb sink cannot connect to the iotdb instance (version >= 0.13.x).

Expected behavior

IoTDB sink should be used with IoTDB (version >= 0.13.0)

Additional technical information

OS

Mac (Apple M1)
MacOS 13.0.1 (22A400)

Java

java version "17.0.6" 2023-01-17 LTS
Java(TM) SE Runtime Environment (build 17.0.6+9-LTS-190)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.6+9-LTS-190, mixed mode, sharing)

Maven

Java version: 17.0.6, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home
Default locale: zh_CN_#Hans, platform encoding: UTF-8
OS name: "mac os x", version: "13.0.1", arch: "aarch64", family: "mac"

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@SteveYurongSu SteveYurongSu added the bug Something isn't working label Jan 23, 2023
@dominikriemer
Copy link
Member

Hi @SteveYurongSu, awesome, thanks for the great description!
Please ask if you have any questions.
We can also refactor the sink to a one-class structure by extending StreamPipesDataSink instead of the currently used model for the IoTDB sink.

SteveYurongSu added a commit to SteveYurongSu/streampipes that referenced this issue Jan 23, 2023
SteveYurongSu added a commit to SteveYurongSu/streampipes that referenced this issue Jan 24, 2023
SteveYurongSu added a commit to SteveYurongSu/streampipes that referenced this issue Jan 26, 2023
SteveYurongSu added a commit to SteveYurongSu/streampipes that referenced this issue Jan 26, 2023
SteveYurongSu added a commit to SteveYurongSu/streampipes that referenced this issue Jan 26, 2023
SteveYurongSu added a commit to SteveYurongSu/streampipes that referenced this issue Jan 27, 2023
tenthe added a commit that referenced this issue Jan 27, 2023
[#1146] Session based implementation of IoTDB sink (fix issues in current JDBC based implementation)
@bossenti bossenti added this to the 0.91.0 milestone Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants