Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Static Properties by UI validation #2144

Closed
bossenti opened this issue Nov 6, 2023 · 4 comments
Closed

Enhance Static Properties by UI validation #2144

bossenti opened this issue Nov 6, 2023 · 4 comments
Labels
connect Related to the `connect` module (adapters) enhancement New feature or request pipeline elements Relates to pipeline elements ui Anything that affects the UI
Milestone
0.95.0

Comments

@bossenti
Copy link
Contributor

bossenti commented Nov 6, 2023

Body

Currently, user input that is collected via the UI when configuring adapters & pipeline elements is not validated, e.g., for being an integer.
This can lead to frustration for the end user.
Therefore, we should try to build in validation for our static properties so that at least data types are validated automatically and maybe even additional validation criteria can be defined.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
@bossenti bossenti added this to the 0.95.0 milestone Nov 6, 2023
@bossenti bossenti added enhancement New feature or request ui Anything that affects the UI pipeline elements Relates to pipeline elements connect Related to the `connect` module (adapters) labels Nov 6, 2023
@IsaakKrut
Copy link
Contributor

Hi @bossenti, I looked at the adapters creation page and saw some validation is already in place. For example:
image

Could you please clarify what properties you are referring to and where they can be found?

@tenthe
Copy link
Contributor

tenthe commented Dec 22, 2023

Hi @IsaakKrut,
can you please check if the validation also validates that the input is an integer?
Is there an error message when you enter "9092.0"?

@IsaakKrut
Copy link
Contributor

@tenthe it does not, but it shows an error with exception stack trace when it tries to connect and guess the schema. I did find 3 adapters that do not have UI validation on their port fields: OPC UA, PLC4X MODBUS, ROS Bridge

@tenthe
Copy link
Contributor

tenthe commented Dec 27, 2023 •
edited
Loading

Ok great. Then this is a good starting point for this issue. Perhaps we can make a list of the places where validation does not work.

IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 7, 2024
@IsaakKrut
apache#2144 updated port number fields to Integer type for ui validation
5c6e9b0
IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 8, 2024
@IsaakKrut
apache#2144 added migration for Plc4xModbusAdapter
0d0be23
IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 8, 2024
@IsaakKrut
apache#2144 added migration for Plc4xModbusAdapter
4b51b3c
IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 8, 2024
@IsaakKrut
apache#2144 added migration V2 for OpcUaAdapter
f227991
IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 8, 2024
@IsaakKrut
apache#2144 added migration V2 for OpcUaAdapter
eb3014a
IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 8, 2024
@IsaakKrut
apache#2144 added migration for RosBridgeAdapter
fb609d9
IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 9, 2024
@IsaakKrut
apache#2144 Added migration test for Plc4xModbusAdapter
28a522e
IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 17, 2024
@IsaakKrut
apache#2144 Added migration test for RosBridgeAdapter
cc9769b
IsaakKrut added a commit to IsaakKrut/streampipes that referenced this issue Jan 17, 2024
@IsaakKrut
apache#2144 Added migration test for OpcUaAdapterMigrationV2
8b1ade9
tenthe added a commit that referenced this issue Jan 29, 2024
@tenthe
fix(#2144): Fix label generation for migrated elements
af2f621
tenthe added a commit that referenced this issue Jan 29, 2024
@tenthe
fix(#2144): Set default static property values for adapter instance
246b73e
tenthe added a commit that referenced this issue Jan 29, 2024
@tenthe
fix(#2144): Set default static property values for adapter instance
19ade2b
tenthe added a commit that referenced this issue Mar 4, 2024
@tenthe
fix(#2144): Rename test for opc migration v2
9cec95f
tenthe added a commit that referenced this issue Mar 4, 2024
@tenthe
fix(#2144): Add methods to provide default if not set by user
b0d8768
tenthe added a commit that referenced this issue Mar 4, 2024
@tenthe
fix(#2144): Change logic of opc ua migration
484f7b3
tenthe added a commit that referenced this issue Mar 4, 2024
@tenthe
fix(#2144): Update modbus adapater migration
fb345ea
tenthe added a commit that referenced this issue Mar 4, 2024
@tenthe
fix(#2144): Update ros bridge adapter migration
2fc3be7
tenthe added a commit that referenced this issue Mar 5, 2024
@tenthe
fix(#2144): Change default value of replaceTitles
de07528
tenthe added a commit that referenced this issue Mar 6, 2024
@tenthe @IsaakKrut
#2144 Enhance Static Properties by UI validation V2 (#2443)
9cf1473 
* #2144 updated port number fields to Integer type for ui validation

* #2144 added migration for Plc4xModbusAdapter

* #2144 added migration for Plc4xModbusAdapter

* #2144 added migration V2 for OpcUaAdapter

* #2144 added migration V2 for OpcUaAdapter

* #2144 added migration for RosBridgeAdapter

* checkstyle changes

* #2144 Added migration test for Plc4xModbusAdapter

* #2144 Added migration test for RosBridgeAdapter

* #2144 Added migration test for OpcUaAdapterMigrationV2

* fix(#2144): Fix label generation for migrated elements

* fix(#2144): Set default static property values for adapter instance

* fix(#2144): Set default static property values for adapter instance

* Updated OpcUaAdapterMigrationTest (#2454)

* fix(#2144): Rename test for opc migration v2

* fix(#2144): Add methods to provide default if not set by user

* fix(#2144): Change logic of opc ua migration

* fix(#2144): Update modbus adapater migration

* fix(#2144): Update ros bridge adapter migration

* fix(#2144): Change default value of replaceTitles

---------

Co-authored-by: Isaak <[email protected]>
@tenthe tenthe closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
connect Related to the `connect` module (adapters) enhancement New feature or request pipeline elements Relates to pipeline elements ui Anything that affects the UI
Projects
None yet
Milestone
0.95.0
Development

No branches or pull requests
3 participants
@tenthe @IsaakKrut @bossenti