Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FileManager class to be non-static #2708

Closed
tenthe opened this issue Apr 7, 2024 · 0 comments · Fixed by #2709
Closed

Refactor FileManager class to be non-static #2708

tenthe opened this issue Apr 7, 2024 · 0 comments · Fixed by #2709
Labels
refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Milestone
0.95.0

Comments

@tenthe
Copy link
Contributor

tenthe commented Apr 7, 2024

Body

The FileManager class is currently implemented as static, which makes it difficult to test and maintain. Refactoring it to be non-static will improve code organization and testability.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
tenthe added a commit that referenced this issue Apr 7, 2024
@tenthe
refactor(#2708): Make all methods of FileManager none static
0ed7c88
@tenthe tenthe linked a pull request Apr 7, 2024 that will close this issue
refactor(#2708): Make all methods of FileManager none static #2709
Merged
tenthe added a commit that referenced this issue Apr 7, 2024
@tenthe
refactor(#2708): Add unit tests for getAllFiles
024ff2a
tenthe added a commit that referenced this issue Apr 7, 2024
@tenthe
refactor(#2708): Add unit tests for getFile
7688dd1
@bossenti bossenti added this to the 0.95.0 milestone Apr 8, 2024
tenthe added a commit that referenced this issue Apr 8, 2024
@tenthe
refactor(#2708): Add tests in FileManager for storeFile and deleteFile
f4c04b9
tenthe added a commit that referenced this issue Apr 8, 2024
@tenthe
refactor(#2708): Make FileHasher none static and add tests
49bfded
tenthe added a commit that referenced this issue Apr 8, 2024
@tenthe
refactor(#2708): Add unit test for checkFileContentChanged in FileMan…
875a1f4 
…ager
tenthe added a commit that referenced this issue Apr 8, 2024
@tenthe
refactor(#2708): Remove hash code from FileMetadata
1ea7464
@bossenti bossenti added the refactoring Indicates when a pull request or issue contains larger refactoring aspects. label Apr 8, 2024
tenthe added a commit that referenced this issue Apr 8, 2024
@tenthe
refactor(#2708): Make all methods of FileManager none static (#2709)
34accf4 
* refactor(#2708): Make all methods of FileManager none static

* refactor(#2708): Add unit tests for getAllFiles

* refactor(#2708): Add unit tests for getFile

* refactor(#2708): Add tests in FileManager for storeFile and deleteFile

* refactor(#2708): Make FileHasher none static and add tests

* refactor(#2708): Add unit test for checkFileContentChanged in FileManager

* refactor(#2708): Remove hash code from FileMetadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Projects
None yet
Milestone
0.95.0
Development

Successfully merging a pull request may close this issue.

refactor(#2708): Make all methods of FileManager none static apache/streampipes
2 participants
@tenthe @bossenti