Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of Consul env variables #953

Closed
dominikriemer opened this issue Dec 30, 2022 · 0 comments · Fixed by #954
Closed

Improve handling of Consul env variables #953

dominikriemer opened this issue Dec 30, 2022 · 0 comments · Fixed by #954
Assignees
@dominikriemer
Labels
backend Everything that is related to the StreamPipes backend deprecation Assigned to pull requests or issues that introduce a deprecation. java Pull requests that update Java code refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Milestone
0.91.0

Comments

@dominikriemer
Copy link
Member

Body

Currently, the location of Consul to register services needs to be provided by a CONSUL_LOCATION env variable, which is defined in each Dockerfile for production usage and can be manually overridden. CONSUL_LOCATION implicitly requires the hostname and not the complete URL which might cause confusion.

  • Introduce two new environment variables SP_CONSUL_HOST and SP_CONSUL_PORT
  • Deprecate CONSUL_LOCATION
  • Remove CONSUL_LOCATION env variable declaration from all Dockerfiles and use "consul" as default SP_CONSUL_HOST value
  • Use "localhost" as SP_CONSUL_HOST default if SP_DEBUG is set to true

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
@dominikriemer dominikriemer added this to the 1.0.0 milestone Dec 30, 2022
@dominikriemer dominikriemer self-assigned this Dec 30, 2022
@dominikriemer dominikriemer added java Pull requests that update Java code backend Everything that is related to the StreamPipes backend labels Dec 30, 2022
dominikriemer added a commit that referenced this issue Dec 30, 2022
@dominikriemer
Improve handling of Consul env variables (#953)
6864a41
@dominikriemer dominikriemer linked a pull request Dec 30, 2022 that will close this issue
Improve handling of Consul env variables (#953) #954
Merged
dominikriemer added a commit that referenced this issue Dec 30, 2022
@dominikriemer
Improve handling of Consul env variables (#953)
af23e43
@bossenti bossenti added refactoring Indicates when a pull request or issue contains larger refactoring aspects. deprecation Assigned to pull requests or issues that introduce a deprecation. labels Dec 31, 2022
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikriemer dominikriemer

Labels
backend Everything that is related to the StreamPipes backend deprecation Assigned to pull requests or issues that introduce a deprecation. java Pull requests that update Java code refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Projects
None yet
Milestone
0.91.0
Development

Successfully merging a pull request may close this issue.

Improve handling of Consul env variables (#953) apache/streampipes
2 participants
@dominikriemer @bossenti