[#877] add formatting and linting to pipeline-details module #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bossenti
commented
Jan 8, 2023
|
|
||
| <sp-basic-nav-tabs | ||
| [spNavigationItems]="tabs" | ||
| [activeLink]="'sp-quick-edit'" |
There was a problem hiding this comment.
is it correct to adapt this reference as well?
There was a problem hiding this comment.
No, this should not be changed.
This is related to the route and not the component.
The route is registered in the module (see [1])
[1] https://github.com/apache/streampipes/blob/dev/ui/src/app/pipelines/pipelines.module.ts
There was a problem hiding this comment.
Alright, then I'll revert it 🙂
32 tasks
tenthe
requested changes
Jan 9, 2023
|
|
||
| <sp-basic-nav-tabs | ||
| [spNavigationItems]="tabs" | ||
| [activeLink]="'sp-quick-edit'" |
There was a problem hiding this comment.
No, this should not be changed.
This is related to the route and not the component.
The route is registered in the module (see [1])
[1] https://github.com/apache/streampipes/blob/dev/ui/src/app/pipelines/pipelines.module.ts
tenthe
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Apply formatting and linting to module
pipeline-detailsRemarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no