Sp 1065 #1069
Merged
Sp 1065 #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthe
added
enhancement
bossenti
approved these changes
Jan 12, 2023
dominikriemer
requested changes
Jan 12, 2023
| } | ||
|
|
||
| } else if (geoFeature.getGeometry() instanceof LineString) { | ||
| LineString lineString = (LineString) geoFeature.getGeometry(); | ||
| eventProperties.add(JsonEventProperty.getEventProperty("coorindatesLineString", lineString.getCoordinates())); | ||
|
|
||
| sampleValues.put("coorindatesLineString", new GuessTypeInfo("java.lang.Double", lineString.getCoordinates())); |
There was a problem hiding this comment.
is this a type and should be named coordinates?
There was a problem hiding this comment.
Thanks, you are right. It seems to be a typo.
| } else if (geoFeature.getGeometry() instanceof MultiPoint) { | ||
| MultiPoint multiPoint = (MultiPoint) geoFeature.getGeometry(); | ||
| eventProperties.add(JsonEventProperty.getEventProperty("coorindatesMultiPoint", multiPoint.getCoordinates())); | ||
|
|
||
| sampleValues.put("coorindatesMultiPoint", new GuessTypeInfo("java.lang.Double", multiPoint.getCoordinates())); |
| <exclusion> | ||
| <groupId>com.fasterxml.woodstox</groupId> | ||
| <artifactId>woodstox-core</artifactId> | ||
| </exclusion> |
There was a problem hiding this comment.
Does this exclusion have any impact on the S7 driver?
There was a problem hiding this comment.
Hopefully not, we have to validate it with a PLC as soon as it is merged. This is included due to some convergence errors
|
@dominikriemer I have addressed your comments. I also extracted some common strings into a new class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1065 by adding e2e tests for the different formats that can be used in the adapters.
Also enabled the live preview feature for all formats.
Remarks
This PR also removes the underscore dependency and replaces it with jackson-dataformat-xml, which was already registered in the pom.
I also had to adjust some of the parser implementations. This PR provides the basis for further refactoring of those parsers.
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no