Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#877] Format and lint core-model module #1094

Merged
merged 1 commit into from
Jan 16, 2023
Merged

[#877] Format and lint core-model module #1094

merged 1 commit into from
Jan 16, 2023

Conversation

aamirxshaikh
Copy link
Contributor

Purpose

Applying UI linting and formatting to the core-model module. Removing the core-model module from ui/.eslintignore and ui/.prettierignore and fixing formatting and lining.

@bossenti bossenti mentioned this pull request Jan 14, 2023
Closed
32 tasks
bossenti
bossenti approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@bossenti bossenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @aamirxshaikh for your huge support in giving our UI code a common codestyle 🙏🏼

@aamirxshaikh
Copy link
Contributor Author

aamirxshaikh commented Jan 14, 2023 •
edited
Loading

You're welcome, @bossenti. Thanks to you, @smlabt, and @tenthe, for your continuous support. Always happy to learn and contribute more 😀

@bossenti bossenti merged commit a532da1 into apache:dev Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossenti bossenti bossenti approved these changes

@tenthe tenthe tenthe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aamirxshaikh @tenthe @bossenti