Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Fix failing e2e tests #1099

Merged
merged 1 commit into from
Jan 16, 2023
Merged

[hotfix] Fix failing e2e tests #1099

merged 1 commit into from
Jan 16, 2023

Conversation

tenthe
Copy link
Contributor

@tenthe tenthe commented Jan 16, 2023

Purpose

This PR fixes the failing e2e tests.
There were two problems:

  • The data-cy tag data-cy="schema-preview-original-event" was missing for the format tests.
  • The behavior of the CSV parser has been changed. Now it uses Double as default type to ensure that the values do not change during parsing.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@tenthe tenthe added enhancement New feature or request ui Anything that affects the UI backend Everything that is related to the StreamPipes backend testing Relates to any kind of test (unit test, integration, or E2E test). no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). labels Jan 16, 2023
@tenthe tenthe added this to the 1.0.0 milestone Jan 16, 2023
@tenthe tenthe requested a review from dominikriemer January 16, 2023 16:31
@tenthe tenthe merged commit 077fa1c into dev Jan 16, 2023
@tenthe tenthe deleted the hotfix-fix-nightly-build branch January 16, 2023 17:14
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikriemer dominikriemer dominikriemer approved these changes

Assignees

@tenthe tenthe

Labels
backend Everything that is related to the StreamPipes backend enhancement New feature or request no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Milestone
0.91.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tenthe @dominikriemer @bossenti