Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#877] Format and lint CustomMaterial module #1144

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

aamirxshaikh
Copy link
Contributor

Purpose

Applying UI linting and formatting to the CustomMaterial module. Removing the CustomMaterial module from ui/.eslintignore and ui/.prettierignore and fixing formatting.

@bossenti bossenti mentioned this pull request Jan 22, 2023
32 tasks
@bossenti
Copy link
Contributor

Do we want to rename the module to custom-material @tenthe @dominikriemer? Would be consistent with the other module names

@tenthe
Copy link
Contributor

tenthe commented Jan 23, 2023

Yes, I think that is a good idea.
We should also discuss if we still need this module. We should address the question whether it is good practice to make all dependencies into one module which is then imported by all others or if it is better to import the material modules directly.

@bossenti
Copy link
Contributor

👍🏼
But that's a follow-up topic right? 🙂

@tenthe
Copy link
Contributor

tenthe commented Jan 23, 2023

Yes, that is a follow up topic

@tenthe tenthe merged commit 6a5b00d into apache:dev Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants