-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1190] Apache TubeMQ (InLong) Adapter & Sink #1191
Conversation
…pes into tubemq-sink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR.
I added a minor comment, but this is a rather small change.
One more hint. For sinks we have a newer API StreamPipesDataSink
, this requires only one class instead of three. Here are two example [1], [2].
This can also be addressed later, the requested changes for the PR are only related to the wrong service name.
[1] https://github.com/apache/streampipes/blob/dev/streampipes-extensions/streampipes-sinks-internal-jvm/src/main/java/org/apache/streampipes/sinks/internal/jvm/datalake/DataLakeSink.java
[2] https://github.com/apache/streampipes/blob/dev/streampipes-extensions/streampipes-sinks-brokers-jvm/src/main/java/org/apache/streampipes/sinks/brokers/jvm/pulsar/PulsarPublisherSink.java
@tenthe Thanks a lot for the reviewing! Sorry for the wrong service name. I have fixed them.
Yes, this time I already implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for your contribution @SteveYurongSu 🙏🏼
Impressive how far you got on your own!
How was your experience with the extensibility of StreamPipes for adapters and sinks? Did you get the required information easily?
|
||
Consumes messages from an Apache TubeMQ broker. | ||
|
||
*** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly required, but it would be awesome if you could add a short descriptionof the input parameters here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Description is added :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Overall, the experience was very good. I mainly got the necessary information from the following two links:
In addition, I have to say that streampipes are too suitable for iot developers! I'm going to contribute some more code related to the IoTDB eco :) |
Glad to hear! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nick work! Thanks @SteveYurongSu
Background
Apache TubeMQ (now is a submodule of Apache Inlong) is a trillion-records-scale distributed messaging queue (MQ) system, focuses on data transmission and storage under massive data. Compared to many open source MQ projects, TubeMQ has unique advantages in terms of stability, performance, and low cost.
It offers a variety of features:
For more information:
Approach
Connect Adapter:
Introduce the TubeMQProtocol for reading data from TubeMQ brokers.
Sink:
Introduce the TubeMQPublisherSink for writing data to TubeMQ brokers.
Remarks
PR introduces (a) breaking change(s): <yes/no>
no
PR introduces (a) deprecation(s): <yes/no>
no