Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STREAMPIPES-604] Add NGINX volume to compose deployment #126

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

obermeier
Copy link
Member

Sometimes it is usefull to change the configururation of the NGINX-Proxy.

E.g. to provide REST-Endpoints on a different port

@obermeier obermeier changed the title [STREAMPIPES-604] Add NGINX volume to compose deplyment [STREAMPIPES-604] Add NGINX volume to compose deployment Oct 24, 2022
@dominikriemer
Copy link
Member

Cool! Should we also add the volume to the docker-compose files in installer/compose?

@obermeier
Copy link
Member Author

Cool! Should we also add the volume to the docker-compose files in installer/compose?

In my eyes this is a very good idea.
In the k8s deployment descriptor too?

@tenthe
Copy link
Contributor

tenthe commented Oct 26, 2022

When users want to use SSL, they also have to change the nginx configurations in the docker-compose file, as described in Documentation.
Do we have to consider or adjust anything here with the new volume mapping?

@obermeier
Copy link
Member Author

I think the the Documentation is still valid.

@obermeier
Copy link
Member Author

Is it a good solution to store the configuration and certificates in the same volume?

@tenthe
Copy link
Contributor

tenthe commented Oct 26, 2022

Good question, I am not sure.
The location of the certificate is defined in /ui/nginx_config/ssl.conf.
I guess we can just change it there if we want to use two different volumes.
What do you think?

@obermeier
Copy link
Member Author

Good question, I am not sure. The location of the certificate is defined in /ui/nginx_config/ssl.conf. I guess we can just change it there if we want to use two different volumes. What do you think?

Yes I like this idear

@obermeier
Copy link
Member Author

I realized that the volumes in k8s overrides the files from the docker image. (I should have known it.)
In this case the configuration must be placed to the volume via ConfigMap, SideCar, copy from ...
Since there is a good default configuration and adding a volume is easy this task could be left to the user!?
If he wants to change the configuration and persist this changes.

For this reason I removed the volume for the nginx configuration

@dominikriemer dominikriemer merged commit 6b8266d into dev Oct 27, 2022
@dominikriemer dominikriemer deleted the obermeier-patch-1 branch October 27, 2022 19:08
@bossenti bossenti linked an issue Nov 27, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume for NGINX configuration
3 participants