[STREAMPIPES-616] refactor cumsum processor #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bossenti
added
java
Co-authored-by: smlabt <[email protected]>
bossenti
force-pushed
the
chore/STREAMPIPES-616
branch
from
94f7671 to
75e0bba
Compare
grainier
reviewed
Nov 6, 2022
...va/org/apache/streampipes/processors/changedetection/jvm/welford/WelfordChangeDetection.java
Show resolved
Hide resolved
grainier
reviewed
Nov 6, 2022
.../main/resources/org.apache.streampipes.processors.changedetection.jvm.cusum/documentation.md
Outdated
Show resolved
Hide resolved
grainier
reviewed
Nov 6, 2022
...vm/src/main/resources/org.apache.streampipes.processors.changedetection.jvm.cusum/strings.en
Outdated
Show resolved
Hide resolved
grainier
reviewed
Nov 6, 2022
.../src/main/resources/org.apache.streampipes.processors.changedetection.jvm.welford/strings.en
Outdated
Show resolved
Hide resolved
…-jvm/src/main/java/org/apache/streampipes/processors/changedetection/jvm/welford/WelfordChangeDetection.java remove empty line Co-authored-by: Grainier Perera <[email protected]>
…-jvm/src/main/resources/org.apache.streampipes.processors.changedetection.jvm.cusum/documentation.md Co-authored-by: Grainier Perera <[email protected]>
…-jvm/src/main/resources/org.apache.streampipes.processors.changedetection.jvm.cusum/strings.en Co-authored-by: Grainier Perera <[email protected]>
…-jvm/src/main/resources/org.apache.streampipes.processors.changedetection.jvm.welford/strings.en Co-authored-by: Grainier Perera <[email protected]>
|
thanks a lot @grainier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: smlabt [email protected]
Purpose
Collaboratively with @smlabt, I've refactored cusum processor from the old three-class-based approach to the new one-class-based approach for designing processing elements.
Approach
We marked the three abstract class that have been used for describing processing elements as deprecated from the current version on. Additionally, we decided to rename the refactored processing element to better reflect it's intention.
For backwards compatibility, we decided to keep the old processing element and mark it as deprecated too. So we can remove it after one or two releases.
Remarks
Fixes: STREAMPIPES-616
We will use STREAMPIPES-615 to refactor the existing processing elements step by step.
Deprecation