Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map http 404 to Java Optional.empty [#1520] #1521

Merged
merged 4 commits into from
Apr 29, 2023
Merged

Map http 404 to Java Optional.empty [#1520] #1521

merged 4 commits into from
Apr 29, 2023

Conversation

obermeier
Copy link
Member

@obermeier obermeier commented Apr 26, 2023 •
edited
Loading

Fixes #1520
Fixes #1522

@github-actions github-actions bot added backend Everything that is related to the StreamPipes backend dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Apr 26, 2023
dominikriemer
dominikriemer approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@dominikriemer dominikriemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @obermeier!

@bossenti bossenti merged commit 5674efe into apache:dev Apr 29, 2023
flomickl pushed a commit that referenced this pull request May 1, 2023
@obermeier @flomickl
Map http 404 to Java Optional.empty [#1520] (#1521)
6b45612 
* Add variable to set location of checkstyle base path

* Fix checkstyle.config.base.path in streampipes-client

* Map REST 404 to Optional.empty in Java

* Return 404 if requested pipeline does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossenti bossenti bossenti approved these changes

@dominikriemer dominikriemer dominikriemer approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return 404 if requested pipeline does not exist Map http 404 to Java Optional.empty in Java Client
3 participants
@obermeier @dominikriemer @bossenti