Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1199] Semantic type Dropdown Fixes for showing full term #1526

Merged
merged 2 commits into from
Apr 29, 2023
Merged

[#1199] Semantic type Dropdown Fixes for showing full term #1526

merged 2 commits into from
Apr 29, 2023

Conversation

abhishek423
Copy link
Contributor

Purpose

Fixes for #1199 with below proposed changes

  • Pop up a tooltip (with full term value) while hovering on dropdown value.
  • Increased dropdown width from 300px to 400px.

Please find the proposed fixes layout in below image
image

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added the ui Anything that affects the UI label Apr 28, 2023
@abhishek423
Copy link
Contributor Author

Hi @bossenti ,

Please find my PR for review and let me know if any feedback/suggestion.
Thanks for the guidance and support :)

dominikriemer
dominikriemer approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@dominikriemer dominikriemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @abhishek423!

@bossenti bossenti linked an issue Apr 29, 2023 that may be closed by this pull request
UI Semantik Type field is too small to see full term #1199
Closed
bossenti
bossenti approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@bossenti bossenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @abhishek423 🙏🏼

@bossenti bossenti merged commit 49680ba into apache:dev Apr 29, 2023
flomickl pushed a commit that referenced this pull request May 1, 2023
@abhishek423 @flomickl
Semantic type dropdown UI fixes (#1526)
6ea4530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossenti bossenti bossenti approved these changes

@dominikriemer dominikriemer dominikriemer approved these changes

Assignees
No one assigned
Labels
ui Anything that affects the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Semantik Type field is too small to see full term
3 participants
@abhishek423 @dominikriemer @bossenti