fix: orchestrate adapter health check such that monitoring of adapters works as expected #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bossenti
added
the
refactoring
github-actions
bot
added
java
tenthe
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#2328 introduced a bug where monitoring metrics were not exposed anymore for running adapters due to a side effect of
getAdaptersToRecover().This PR introduces a fix so that metrics are exposed again for all adapters running and makes metric emitting more robust. However, parts of the introduced changes are only to be seen as a workaround.
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no