Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not overwrite timestamp in output event of a function #2548

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix: do not overwrite timestamp in output event of a function #2548

merged 3 commits into from
Mar 13, 2024

Conversation

bossenti
Copy link
Contributor

@bossenti bossenti commented Mar 13, 2024 •
edited
Loading

Purpose

So far a function always sets the timestamp of an outgoing event to the current time.
This should only be the case if there is no timestamp available

Remarks

PR introduces (a) breaking change(s): yes

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added the python Pull requests that update Python code label Mar 13, 2024
@bossenti bossenti added the breaking change Indicates that a PR or issue yields to a breaking change label Mar 13, 2024
@bossenti bossenti added this to the 0.95.0 milestone Mar 13, 2024
@bossenti bossenti merged commit 5f1107a into dev Mar 13, 2024
18 checks passed
@bossenti bossenti deleted the fix-function-output-timestamp branch March 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvenO3 SvenO3 SvenO3 approved these changes

Assignees
No one assigned
Labels
breaking change Indicates that a PR or issue yields to a breaking change python Pull requests that update Python code
Projects
None yet
Milestone
0.95.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bossenti @SvenO3