Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable check style for streampipes-integration-tests #814

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

RobertIndie
Copy link
Member

@RobertIndie RobertIndie commented Nov 29, 2022

Purpose

Discussion: #815

Master issue: #820

Enable check style for streampipes-integration-tests.

This is the first try to enable checkstyle for the repo. I use the module streampipes-integration-tests as the example here.
If we are good with this PR, then we can apply it to all other modules gradually.

Approach

  • Add the Indentation convention to the checkstyle.xml. I saw that we use the different Indentation convention in the repo. Here I use the google_checks.xml as the Indentation convention, which works for most of our codes.
  • Change checkstyle-header to make it compatible with most of codes.
  • Reformat the code in streampipes-integration-tests

Validation

  1. Make sure you are at the root path of the project
  2. Run maven validate -f streampipes-integration-tests

Samples

Remarks

Copy link
Contributor

@bossenti bossenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for taking over the initiative @RobertIndie 🙏🏼
Do we want to create an issue to track the progress with validating all modules?

@RobertIndie RobertIndie mentioned this pull request Nov 30, 2022
97 tasks
@RobertIndie
Copy link
Member Author

Do we want to create an issue to track the progress with validating all modules?

Great idea. I have created an issue to track it: #820

@RobertIndie RobertIndie merged commit d377291 into apache:dev Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants