Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example files python client #846

Merged
merged 4 commits into from
Dec 12, 2022
Merged

Conversation

bossenti
Copy link
Contributor

@bossenti bossenti commented Dec 4, 2022

Purpose

Provide some tutorials for the Python client.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@bossenti bossenti added this to the 1.0.0 milestone Dec 4, 2022
@bossenti bossenti force-pushed the add-example-files-python-client branch 2 times, most recently from 3275de8 to 4297388 Compare December 4, 2022 20:55
@bossenti
Copy link
Contributor Author

bossenti commented Dec 4, 2022

@dominikriemer @tenthe any idea how to properly put the Apache License header to Jupyter Notebooks?

@tenthe
Copy link
Contributor

tenthe commented Dec 5, 2022

I am not sure if this is even possible. It looks like it is json, right?
I saw one solution that suggested to add a dedicated json field for the license information, but I do not think that is a standard way. If it is not possible, we have to exclude it in the apache-rat-plugin configuration in thepom.xml file. There we already exluce .csv & .json files.

@bossenti
Copy link
Contributor Author

I am not sure if this is even possible. It looks like it is json, right?

@tenthe yes, exactly .ipynb is basically JSON.
I will try to add the license as meta information and exclude jupyter notebooks in the rat-plugin

@bossenti bossenti force-pushed the add-example-files-python-client branch from ac33fb6 to 34add0b Compare December 10, 2022 12:48
@bossenti bossenti merged commit 00f2391 into dev Dec 12, 2022
@bossenti bossenti deleted the add-example-files-python-client branch December 12, 2022 19:44
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023
@bossenti bossenti self-assigned this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants