Fix the checkstyle plugin doesn't fail on violation #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
changed the title
97 tasks
bossenti
approved these changes
Dec 7, 2022
|
Hi @RobertIndie, thanks a lot. I'll directly merge it, so I can use the changes for my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #820 (comment)
The root cause is that the plugin configuration of the submodule is inherited from the parent project. We have skipped
failOnViolationin the parent pom. Therefore the submodule also skips that.This PR makes the checkstyle configuration of the parent module not be inherited to the submodule.
After we complete this issue: #820, we can turn it back and let the checkstyle configuration of the parent module apply to the whole project.
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no