Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#820] Enable checkstyle for streampipes-config and add suppress support for checkstyle #863

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

RobertIndie
Copy link
Member

Purpose

Master Issue: #820

  • Enable checkstyle for streampipes-config
  • Add suppress support for checkstyle, now we can use this way to suppress the style check before the code:
@SuppressWarnings("checkstyle:{Rule-name}")
...

I found that there is an issue in the IDEA: https://youtrack.jetbrains.com/issue/IDEA-80495/Settings-Operation-sign-on-next-line-does-not-work-for-automatically-breaking-strings.
Therefore, we seem couldn't reformat the code according to the OperatorWrap rule automatically. Haven't found a good solution yet. We could only format it manually.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@RobertIndie RobertIndie self-assigned this Dec 12, 2022
@RobertIndie RobertIndie mentioned this pull request Dec 12, 2022
97 tasks
Copy link
Contributor

@bossenti bossenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool to have this decorator syntax 👍🏼

@RobertIndie RobertIndie merged commit 7e7eb4b into apache:dev Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants