lint

superset/reports/commands/alert.py

@@ -147,7 +147,7 @@ def _execute_query(self) -> pd.DataFrame:
             )
             return self._report_schedule.database.get_df(limited_rendered_sql)
         except SoftTimeLimitExceeded as ex:
-            logger.error("A timeout occurred while executing the alert query: %s",  ex)
+            logger.error("A timeout occurred while executing the alert query: %s", ex)
             raise AlertQueryTimeout()
         except Exception as ex:
             raise AlertQueryError(message=str(ex))

superset/sql_lab.py

@@ -161,7 +161,7 @@ def get_sql_results(  # pylint: disable=too-many-arguments
             )
         except SoftTimeLimitExceeded as ex:
             logger.error("Query %d: Time limit exceeded", query_id)
-            logger.debug("Query %d: %s", query.id, ex)
+            logger.debug("Query %d: %s", query_id, ex)
             raise SqlLabTimeoutException(
                 "SQL Lab timeout. This environment's policy is to kill queries "
                 "after {} seconds.".format(SQLLAB_TIMEOUT)

superset/tasks/async_queries.py

@@ -18,8 +18,8 @@
 import logging
 from typing import Any, cast, Dict, Optional
 
-from flask import current_app
 from celery.exceptions import SoftTimeLimitExceeded
+from flask import current_app
 
 from superset import app
 from superset.exceptions import SupersetVizException
@@ -37,9 +37,9 @@
 def load_chart_data_into_cache(
     job_metadata: Dict[str, Any], form_data: Dict[str, Any],
 ) -> None:
-    from superset.charts.commands.data import (
+    from superset.charts.commands.data import (  # load here due to circular imports
         ChartDataCommand,
-    )  # load here due to circular imports
+    )
 
     with app.app_context():  # type: ignore
         try:
@@ -67,7 +67,7 @@ def load_chart_data_into_cache(
 
 
 @celery_app.task(name="load_explore_json_into_cache", soft_time_limit=query_timeout)
-def load_explore_json_into_cache(
+def load_explore_json_into_cache(  # pylint: disable-msg=too-many-locals
     job_metadata: Dict[str, Any],
     form_data: Dict[str, Any],
     response_type: Optional[str] = None,

superset/tasks/scheduler.py

@@ -19,9 +19,9 @@
 from typing import Iterator
 
 import croniter
+from celery.exceptions import SoftTimeLimitExceeded
 from dateutil import parser
 
-from celery.exceptions import SoftTimeLimitExceeded
 from superset import app
 from superset.commands.exceptions import CommandException
 from superset.extensions import celery_app