rename method name

apache · Mar 26, 2024 · 5458cfa · 5458cfa
1 parent 3004f68
commit 5458cfa
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 23 deletions.
diff --git a/superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelItem.test.tsx b/superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelItem.test.tsx
@@ -32,13 +32,13 @@ const mockData = {
   totalColumns: Math.max(columns.length, 13),
   width: 300,
   showAllMetrics: false,
-  setShowAllMetrics: jest.fn(),
+  onShowAllMetricsChange: jest.fn(),
   showAllColumns: false,
-  setShowAllColumns: jest.fn(),
+  onShowAllColumnsChange: jest.fn(),
   collapseMetrics: false,
-  setCollapseMetrics: jest.fn(),
+  onCollapseMetricsChange: jest.fn(),
   collapseColumns: false,
-  setCollapseColumns: jest.fn(),
+  onCollapseColumnsChange: jest.fn(),
 };
 
 test('renders each item accordingly', () => {
@@ -117,15 +117,15 @@ test('renders each item accordingly', () => {
 });
 
 test('can collapse metrics and columns', () => {
-  mockData.setCollapseMetrics.mockClear();
-  mockData.setCollapseColumns.mockClear();
+  mockData.onCollapseMetricsChange.mockClear();
+  mockData.onCollapseColumnsChange.mockClear();
   const { queryByText, getByRole, rerender } = render(
     <DatasourcePanelItem index={0} data={mockData} style={{}} />,
     { useDnd: true },
   );
   fireEvent.click(getByRole('button'));
-  expect(mockData.setCollapseMetrics).toBeCalled();
-  expect(mockData.setCollapseColumns).not.toBeCalled();
+  expect(mockData.onCollapseMetricsChange).toBeCalled();
+  expect(mockData.onCollapseColumnsChange).not.toBeCalled();
 
   const startIndexOfColumnSection = mockData.metricSlice.length + 3;
   rerender(
@@ -136,7 +136,7 @@ test('can collapse metrics and columns', () => {
     />,
   );
   fireEvent.click(getByRole('button'));
-  expect(mockData.setCollapseColumns).toBeCalled();
+  expect(mockData.onCollapseColumnsChange).toBeCalled();
 
   rerender(
     <DatasourcePanelItem

diff --git a/superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelItem.tsx b/superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelItem.tsx
@@ -44,13 +44,13 @@ type Props = {
     totalColumns: number;
     width: number;
     showAllMetrics: boolean;
-    setShowAllMetrics: (showAll: boolean) => void;
+    onShowAllMetricsChange: (showAll: boolean) => void;
     showAllColumns: boolean;
-    setShowAllColumns: (showAll: boolean) => void;
+    onShowAllColumnsChange: (showAll: boolean) => void;
     collapseMetrics: boolean;
-    setCollapseMetrics: (collapse: boolean) => void;
+    onCollapseMetricsChange: (collapse: boolean) => void;
     collapseColumns: boolean;
-    setCollapseColumns: (collapse: boolean) => void;
+    onCollapseColumnsChange: (collapse: boolean) => void;
   };
 };
 
@@ -138,13 +138,13 @@ const DatasourcePanelItem: React.FC<Props> = ({ index, style, data }) => {
     totalColumns,
     width,
     showAllMetrics,
-    setShowAllMetrics,
+    onShowAllMetricsChange,
     showAllColumns,
-    setShowAllColumns,
+    onShowAllColumnsChange,
     collapseMetrics,
-    setCollapseMetrics,
+    onCollapseMetricsChange,
     collapseColumns,
-    setCollapseColumns,
+    onCollapseColumnsChange,
   } = data;
   const metricSlice = collapseMetrics ? [] : _metricSlice;
 
@@ -161,9 +161,13 @@ const DatasourcePanelItem: React.FC<Props> = ({ index, style, data }) => {
     (collapseMetrics ? HEADER_LINE : SUBTITLE_LINE) +
     1;
   const collapsed = isColumnSection ? collapseColumns : collapseMetrics;
-  const setCollapse = isColumnSection ? setCollapseColumns : setCollapseMetrics;
+  const setCollapse = isColumnSection
+    ? onCollapseColumnsChange
+    : onCollapseMetricsChange;
   const showAll = isColumnSection ? showAllColumns : showAllMetrics;
-  const setShowAll = isColumnSection ? setShowAllColumns : setShowAllMetrics;
+  const setShowAll = isColumnSection
+    ? onShowAllColumnsChange
+    : onShowAllMetricsChange;
   const theme = useTheme();
 
   return (

diff --git a/superset-frontend/src/explore/components/DatasourcePanel/index.tsx b/superset-frontend/src/explore/components/DatasourcePanel/index.tsx
@@ -324,13 +324,13 @@ export default function DataSourcePanel({
                   totalMetrics: lists?.metrics.length,
                   totalColumns: lists?.columns.length,
                   showAllMetrics,
-                  setShowAllMetrics,
+                  onShowAllMetricsChange: setShowAllMetrics,
                   showAllColumns,
-                  setShowAllColumns,
+                  onShowAllColumnsChange: setShowAllColumns,
                   collapseMetrics,
-                  setCollapseMetrics,
+                  onCollapseMetricsChange: setCollapseMetrics,
                   collapseColumns,
-                  setCollapseColumns,
+                  onCollapseColumnsChange: setCollapseColumns,
                 }}
                 overscanCount={5}
               >