Address some comments

apache · Aug 9, 2022 · 5adb031 · 5adb031
1 parent 5eccb92
commit 5adb031
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx
@@ -330,6 +330,7 @@ export default styled(BigNumberVis)`
     display: flex;
     flex-direction: column;
     justify-content: center;
+    align-items: flex-start;
 
     &.no-trendline .subheader-line {
       padding-bottom: 0.3em;

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Treemap/EchartsTreemap.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/Treemap/EchartsTreemap.tsx
@@ -93,12 +93,12 @@ export default function EchartsTreemap({
         if (treePath.length > 0) {
           const pointerEvent = eventParams.event.event;
           const filters: QueryObjectFilterClause[] = [];
-          groupby.forEach((dimension, i) =>
+          treePath.forEach((path, i) =>
             filters.push({
-              col: dimension,
+              col: groupby[i],
               op: '==',
-              val: treePath[i],
-              formattedVal: treePath[i],
+              val: path,
+              formattedVal: path,
             }),
           );
           onContextMenu(filters, pointerEvent.offsetX, pointerEvent.offsetY);