Add semantic-object-key-val as argument for onHover prop

apache · Mar 27, 2024 · 5ca3c1b · 5ca3c1b
1 parent a1d5c77
commit 5ca3c1b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
@@ -238,7 +238,8 @@ class Row extends React.PureComponent {
   }
 
   handleMenuHover = hovered => {
-    this.setState(() => ({ hoverMenuHovered: hovered }));
+    const { isHovered } = hovered;
+    this.setState(() => ({ hoverMenuHovered: isHovered }));
   };
 
   render() {

diff --git a/superset-frontend/src/dashboard/components/menu/HoverMenu.tsx b/superset-frontend/src/dashboard/components/menu/HoverMenu.tsx
@@ -25,7 +25,7 @@ interface HoverMenuProps {
   position: 'left' | 'top';
   innerRef: RefObject<HTMLDivElement>;
   children: React.ReactNode;
-  onHover?: (isHovered: boolean) => void;
+  onHover?: (data: { isHovered: boolean }) => void;
 }
 
 const HoverStyleOverrides = styled.div`
@@ -73,14 +73,16 @@ export default class HoverMenu extends React.PureComponent<HoverMenuProps> {
   };
 
   handleMouseEnter = () => {
-    if (this.props.onHover) {
-      this.props.onHover(true);
+    const { onHover } = this.props;
+    if (onHover) {
+      onHover({ isHovered: true });
     }
   };
 
   handleMouseLeave = () => {
-    if (this.props.onHover) {
-      this.props.onHover(false);
+    const { onHover } = this.props;
+    if (onHover) {
+      onHover({ isHovered: false });
     }
   };