Skip to content

Commit

Permalink
fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
villebro committed Feb 18, 2021
1 parent 851aa5d commit 63a1f0f
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions tests/db_engine_specs/pinot_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def test_pinot_time_expression_sec_one_1d_grain(self):
self.assertEqual(
result,
"DATETIMECONVERT(tstamp, '1:SECONDS:EPOCH', '1:SECONDS:EPOCH', '1:DAYS')",
) # noqa
)

def test_pinot_time_expression_simple_date_format_1d_grain(self):
col = column("tstamp")
Expand All @@ -43,7 +43,7 @@ def test_pinot_time_expression_simple_date_format_1d_grain(self):
+ "'1:SECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss', "
+ "'1:SECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss', '1:DAYS')"
),
) # noqa
)

def test_pinot_time_expression_simple_date_format_1w_grain(self):
col = column("tstamp")
Expand All @@ -55,25 +55,21 @@ def test_pinot_time_expression_simple_date_format_1w_grain(self):
"ToDateTime(DATETRUNC('week', FromDateTime(tstamp, "
+ "'yyyy-MM-dd HH:mm:ss'), 'MILLISECONDS'), 'yyyy-MM-dd HH:mm:ss')"
),
) # noqa
)

def test_pinot_time_expression_sec_one_1m_grain(self):
col = column("tstamp")
expr = PinotEngineSpec.get_timestamp_expr(col, "epoch_s", "P1M")
result = str(expr.compile())
self.assertEqual(
result, "DATETRUNC('month', tstamp, 'SECONDS')",
) # noqa
)

def test_invalid_get_time_expression_arguments(self):
with self.assertRaises(NotImplementedError) as context:
with self.assertRaises(NotImplementedError):
PinotEngineSpec.get_timestamp_expr(column("tstamp"), None, "P1M")
self.assertEqual("Empty date format for 'tstamp'", str(context.exception))

with self.assertRaises(NotImplementedError) as context:
with self.assertRaises(NotImplementedError):
PinotEngineSpec.get_timestamp_expr(
column("tstamp"), "epoch_s", "invalid_grain"
)
self.assertEqual(
"No pinot grain spec for 'invalid_grain'", str(context.exception)
)

0 comments on commit 63a1f0f

Please sign in to comment.