Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pin ipython, exclude new pylint rules
Browse files Browse the repository at this point in the history
bogdan-dbx committed Aug 25, 2020
1 parent 8178c43 commit 66fe3a4
Showing 4 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ confidence=
# --enable=similarities". If you want to run only the classes checker, but have
# no Warning level messages displayed, use"--disable=all --enable=classes
# --disable=W"
disable=standarderror-builtin,long-builtin,dict-view-method,intern-builtin,suppressed-message,no-absolute-import,unpacking-in-except,apply-builtin,delslice-method,indexing-exception,old-raise-syntax,print-statement,cmp-builtin,reduce-builtin,useless-suppression,coerce-method,input-builtin,cmp-method,raw_input-builtin,nonzero-method,backtick,basestring-builtin,setslice-method,reload-builtin,oct-method,map-builtin-not-iterating,execfile-builtin,old-octal-literal,zip-builtin-not-iterating,buffer-builtin,getslice-method,metaclass-assignment,xrange-builtin,long-suffix,round-builtin,range-builtin-not-iterating,next-method-called,dict-iter-method,parameter-unpacking,unicode-builtin,unichr-builtin,import-star-module-level,raising-string,filter-builtin-not-iterating,old-ne-operator,using-cmp-argument,coerce-builtin,file-builtin,old-division,hex-method,invalid-unary-operand-type,missing-docstring,too-many-lines,duplicate-code,bad-continuation,ungrouped-imports,import-outside-toplevel
disable=standarderror-builtin,long-builtin,dict-view-method,intern-builtin,suppressed-message,no-absolute-import,unpacking-in-except,apply-builtin,delslice-method,indexing-exception,old-raise-syntax,print-statement,cmp-builtin,reduce-builtin,useless-suppression,coerce-method,input-builtin,cmp-method,raw_input-builtin,nonzero-method,backtick,basestring-builtin,setslice-method,reload-builtin,oct-method,map-builtin-not-iterating,execfile-builtin,old-octal-literal,zip-builtin-not-iterating,buffer-builtin,getslice-method,metaclass-assignment,xrange-builtin,long-suffix,round-builtin,range-builtin-not-iterating,next-method-called,dict-iter-method,parameter-unpacking,unicode-builtin,unichr-builtin,import-star-module-level,raising-string,filter-builtin-not-iterating,old-ne-operator,using-cmp-argument,coerce-builtin,file-builtin,old-division,hex-method,invalid-unary-operand-type,missing-docstring,too-many-lines,duplicate-code,bad-continuation,ungrouped-imports,import-outside-toplevel,raise-missing-from,super-with-arguments,bad-option-value


[REPORTS]
3 changes: 3 additions & 0 deletions requirements/testing.in
Original file line number Diff line number Diff line change
@@ -19,6 +19,9 @@
flask-testing
docker
ipdb
# pinning ipython as pip-compile-multi was bringing higher version
# of the ipython that was not found in CI
ipython==7.16.1
openapi-spec-validator
openpyxl
parameterized
4 changes: 2 additions & 2 deletions requirements/testing.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SHA1:f6706bfe80b8fe1a66af5e3d3cc453867d0ac451
# SHA1:f9f1fc59b48794bbb4512a857fd5b3c24c33aa1e
#
# This file is autogenerated by pip-compile-multi
# To update, run:
@@ -17,7 +17,7 @@ flask-testing==0.8.0 # via -r requirements/testing.in
iniconfig==1.0.1 # via pytest
ipdb==0.13.3 # via -r requirements/testing.in
ipython-genutils==0.2.0 # via traitlets
ipython==7.17.0 # via ipdb
ipython==7.16.1 # via -r requirements/testing.in, ipdb
isort==5.4.2 # via pylint
jedi==0.17.2 # via ipython
lazy-object-proxy==1.4.3 # via astroid
12 changes: 6 additions & 6 deletions tests/model_tests.py
Original file line number Diff line number Diff line change
@@ -128,7 +128,6 @@ def test_select_star(self):
)
)
assert expected in sql

sql = db.select_star(table_name, show_cols=True, latest_partition=False)
# TODO(bkyryliuk): unify sql generation
if db.backend == "presto":
@@ -138,7 +137,8 @@ def test_select_star(self):
SELECT "source" AS "source",
"target" AS "target",
"value" AS "value"
FROM "energy_usage"\nLIMIT 100"""
FROM "energy_usage"
LIMIT 100"""
)
== sql
)
@@ -147,8 +147,8 @@ def test_select_star(self):
textwrap.dedent(
"""\
SELECT `source`,
`target`,
`value`
`target`,
`value`
FROM `energy_usage`
LIMIT 100"""
)
@@ -159,8 +159,8 @@ def test_select_star(self):
textwrap.dedent(
"""\
SELECT source,
target,
value
target,
value
FROM energy_usage
LIMIT 100"""
)

0 comments on commit 66fe3a4

Please sign in to comment.