localize error message, fix review comments.

apache · Mar 25, 2020 · 735b21c · 735b21c
1 parent 6dd2258
commit 735b21c
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx b/superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
@@ -69,17 +69,15 @@ const propTypes = {
 
 const defaultProps = {};
 
-const markdownPlaceHolder = `# ✨Markdown
+const MARKDOWN_PLACE_HOLDER = `# ✨Markdown
 ## ✨Markdown
 ### ✨Markdown
 
 <br />
 
 Click here to edit [markdown](https://bit.ly/1dQOfRK)`;
 
-const emergencyCode = `
-  This markdown component has an error.
-`;
+const MARKDOWN_ERROR_MESSAGE = t('This markdown component has an error.');
 
 function isSafeMarkup(node) {
   if (node.type === 'html') {
@@ -243,7 +241,7 @@ class Markdown extends React.PureComponent {
           // thisl allows "select all => delete" to give an empty editor
           typeof this.state.markdownSource === 'string'
             ? this.state.markdownSource
-            : markdownPlaceHolder
+            : MARKDOWN_PLACE_HOLDER
         }
         readOnly={false}
         onLoad={this.setEditor}
@@ -257,8 +255,8 @@ class Markdown extends React.PureComponent {
       <ReactMarkdown
         source={
           hasError
-            ? emergencyCode
-            : this.state.markdownSource || markdownPlaceHolder
+            ? MARKDOWN_ERROR_MESSAGE
+            : this.state.markdownSource || MARKDOWN_PLACE_HOLDER
         }
         escapeHtml={false}
         allowNode={isSafeMarkup}