Use paginated_update

apache · Dec 21, 2023 · 8586275 · 8586275
1 parent e54f29d
commit 8586275
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/...migrations/versions/2023-12-15_17-58_06dd9ff00fe8_add_percent_calculation_type_funnel_.py b/...migrations/versions/2023-12-15_17-58_06dd9ff00fe8_add_percent_calculation_type_funnel_.py
@@ -28,6 +28,7 @@
 from sqlalchemy.ext.declarative import declarative_base
 
 from superset import db
+from superset.migrations.shared.utils import paginated_update
 
 # revision identifiers, used by Alembic.
 revision = "06dd9ff00fe8"
@@ -47,7 +48,9 @@ def upgrade():
     bind = op.get_bind()
     session = db.Session(bind=bind)
 
-    for slc in session.query(Slice).filter(Slice.viz_type == "funnel"):
+    for slc in paginated_update(
+        session.query(Slice).filter(Slice.viz_type == "funnel")
+    ):
         params = json.loads(slc.params)
         percent_calculation = params.get("percent_calculation_type")
         if not percent_calculation:
@@ -61,7 +64,9 @@ def downgrade():
     bind = op.get_bind()
     session = db.Session(bind=bind)
 
-    for slc in session.query(Slice).filter(Slice.viz_type == "funnel"):
+    for slc in paginated_update(
+        session.query(Slice).filter(Slice.viz_type == "funnel")
+    ):
         params = json.loads(slc.params)
         percent_calculation = params.get("percent_calculation_type")
         if percent_calculation: