Skip to content

Commit

Permalink
replace with since-until with time_range
Browse files Browse the repository at this point in the history
  • Loading branch information
villebro committed Jan 2, 2023
1 parent 6f922bb commit 874fe73
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ describe('Test datatable', () => {
});
it('Data Pane opens and loads results', () => {
cy.contains('Results').click();
cy.get('[data-test="row-count-label"]').contains('44 rows');
cy.get('[data-test="row-count-label"]').contains('26 rows');
cy.get('.ant-empty-description').should('not.exist');
});
it('Datapane loads view samples', () => {
Expand Down
3 changes: 1 addition & 2 deletions superset/examples/birth_names.py
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,7 @@ def create_slices(tbl: SqlaTable) -> Tuple[List[Slice], List[Slice]]:
params=get_slice_json(
defaults,
groupby=["ds"],
since="1950-01-01",
until="2020-01-01",
time_range="1983 : 2023",
viz_type="table",
metrics=metrics,
),
Expand Down

0 comments on commit 874fe73

Please sign in to comment.